nano

commit eaff5ec9e5a4896a6a478e2d72f1d92abbb514a4
parent 51eb938fea559bcd903d0282f1ed9008580be443
Author: Benno Schulenberg <bensberg@telfort.nl>
Date:   Fri, 20 Aug 2021 10:28:42 +0200

files: check the result of fdopen(), to avoid a possible crash

When safe_tempfile() returns a valid filename, it should also
return a valid open stream.

This fixes https://savannah.gnu.org/bugs/?61064.

Bug existed since version 1.3.8, commit 5e068c60.

Diffstat:
M
src/files.c
 | 
8
+++++---

1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/files.c b/src/files.c
@@ -1469,13 +1469,15 @@ char *safe_tempfile(FILE **stream)
 
 	fd = mkstemp(tempfile_name);
 
-	if (fd == -1) {
+	*stream = (fd > 0) ? fdopen(fd, "r+b") : NULL;
+
+	if (*stream == NULL) {
+		if (fd > 0)
+			close(fd);
 		free(tempfile_name);
 		return NULL;
 	}
 
-	*stream = fdopen(fd, "r+b");
-
 	return tempfile_name;
 }