nano

commit 6d3b16b761f428a72afd82d6c8a7d306eb4661cf
parent 89c0e7493f47ee0c4b4b759ac8bd5de2d9c80b5f
Author: Benno Schulenberg <bensberg@telfort.nl>
Date:   Sat, 14 Jul 2018 21:27:50 +0200

tweaks: close a temp file only when descriptor is valid  [coverity scan]

Diffstat:
M
src/text.c
 | 
5
+++--

1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/src/text.c b/src/text.c
@@ -2661,8 +2661,10 @@ const char *do_int_speller(const char *tempfile_name)
 		if ((tempfile_fd = open(tempfile_name, O_RDONLY)) == -1)
 			goto close_pipes_and_exit;
 
-		if (dup2(tempfile_fd, STDIN_FILENO) != STDIN_FILENO)
+		if (dup2(tempfile_fd, STDIN_FILENO) != STDIN_FILENO) {
+			close(tempfile_fd);
 			goto close_pipes_and_exit;
+		}
 
 		close(tempfile_fd);
 
@@ -2808,7 +2810,6 @@ const char *do_int_speller(const char *tempfile_name)
 
   close_pipes_and_exit:
 	/* Don't leak any handles. */
-	close(tempfile_fd);
 	close(spell_fd[0]);
 	close(spell_fd[1]);
 	close(sort_fd[0]);