nano

commit 115aeda69b6f45271b8d4f7a10dcf5261714b30c
parent 17cf833b9c0631d933edcdd298099821c1634707
Author: Mike Scalora <mike@scalora.org>
Date:   Tue, 31 May 2016 21:19:50 +0200

text: keep the file size correct when undoing/redoing a comment/uncomment

Store the file sizes from before and after the commenting/uncommenting
in the undo struct, so they can be restored when undoing or redoing.

This fixes https://savannah.gnu.org/bugs/?48062.

Signed-off-by: Mike Scalora <mike@scalora.org>

Diffstat:
M
src/proto.h
 | 
3
++-
M
src/text.c
 | 
16
+++++++++++-----

2 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/src/proto.h b/src/proto.h
@@ -749,7 +749,8 @@ void discard_until(const undo *thisitem, openfilestruct *thefile);
 void add_undo(undo_type action);
 void update_undo(undo_type action);
 #ifndef DISABLE_COMMENT
-void add_comment_undo(undo_type action, const char *comment_seq, size_t undo_x);
+void add_comment_undo(undo_type action, const char *comment_seq, size_t was_x,
+	size_t was_size);
 void update_comment_undo(ssize_t lineno);
 bool comment_line(undo_type action, filestruct *f, const char *comment_seq);
 #endif
diff --git a/src/text.c b/src/text.c
@@ -443,7 +443,7 @@ void do_comment()
     const char *comment_seq = "#";
     undo_type action = UNCOMMENT;
     filestruct *top, *bot, *f;
-    size_t top_x, bot_x, was_x;
+    size_t top_x, bot_x, was_x, was_size;
     bool empty, all_empty = TRUE;
 
     bool file_changed = FALSE;
@@ -471,8 +471,9 @@ void do_comment()
 	bot = top;
     }
 
-    /* Remember the cursor x position to be restored when undoing. */
+    /* Remember cursor position and file size, to be restored when undoing. */
     was_x = openfile->current_x;
+    was_size = openfile->totsize;
 
     /* Figure out whether to comment or uncomment the selected line or lines. */
     for (f = top; f != bot->next; f = f->next) {
@@ -494,7 +495,7 @@ void do_comment()
 	if (comment_line(action, f, comment_seq)) {
 	    if (!file_changed) {
 		/* Start building undo data on the first modified line. */
-		add_comment_undo(action, comment_seq, was_x);
+		add_comment_undo(action, comment_seq, was_x, was_size);
 		file_changed = TRUE;
 	    }
 	    /* Add undo data for each modified line. */
@@ -1274,7 +1275,8 @@ void add_undo(undo_type action)
 #ifdef ENABLE_COMMENT
 /* Add a comment undo item.  This should be called once for each use
  * of the comment/uncomment feature that modifies the document. */
-void add_comment_undo(undo_type action, const char *comment_seq, size_t was_x)
+void add_comment_undo(undo_type action, const char *comment_seq, size_t was_x,
+	size_t was_size)
 {
     add_undo(action);
 
@@ -1282,8 +1284,9 @@ void add_comment_undo(undo_type action, const char *comment_seq, size_t was_x)
      * change when the file name changes; we need to know what it was. */
     openfile->current_undo->strdata = mallocstrcpy(NULL, comment_seq);
 
-    /* Remember the position of the cursor before the change was made. */
+    /* Store cursor position and file size from before the change. */
     openfile->current_undo->begin = was_x;
+    openfile->current_undo->wassize= was_size;
 }
 
 /* Update a comment undo item.  This should be called once for each line
@@ -1304,6 +1307,9 @@ void update_comment_undo(ssize_t lineno)
 	born->top_line = lineno;
 	born->bottom_line = lineno;
     }
+
+    /* Store the file size after the change, to be used when redoing. */
+    u->newsize = openfile->totsize;
 }
 #endif /* ENABLE_COMMENT */